fix: Enable asm requantized max pooling with differing qinfo#1285
Merged
fix: Enable asm requantized max pooling with differing qinfo#1285
Conversation
gunes-arm
requested changes
Apr 28, 2026
Contributor
gunes-arm
left a comment
gunes-arm
left a comment
There was a problem hiding this comment.
fix: enable asm requantized max pooling with differing qinfo
-->
fix: Enable asm requantized max pooling with differing qinfo
morgolock
force-pushed
the
pr/enable_max_pool_asm_diff_qinfo
branch
from
e640361 to
447d3ad
Compare
gunes-arm
changed the title
gunes-arm
approved these changes
Apr 29, 2026
gunes-arm
requested changes
Apr 29, 2026
Contributor
gunes-arm
left a comment
gunes-arm
left a comment
There was a problem hiding this comment.
Accidental approval last time
morgolock
force-pushed
the
pr/enable_max_pool_asm_diff_qinfo
branch
from
447d3ad to
1ff93da
Compare
Restrict differing src/dst quantization-info support in CpuPool2dAssemblyWrapperKernel to MAX pooling, while keeping AVG pooling on the generic fallback path. Fix the quantized multiplier validation check and wire the requantization shifts correctly for the asm pooling path so requantized MAX pooling validates and executes correctly. Reject padded QASYMM8_SIGNED AVG pooling in the asm wrapper for same-qinfo configurations, matching the existing QASYMM8 policy. Add coverage for QASYMM8_SIGNED padded MAX pooling on the asm path for same qinfo and zero-offset differing qinfo. Add validate coverage for padded NHWC QASYMM8 MAX with differing quantization info. Resolves MLCE-1821 Signed-off-by: Pablo Marquez Tello <pablo.tello@arm.com> Change-Id: I33c99d0d4ea1bf57ed28d0750422403e60e2a276
morgolock
force-pushed
the
pr/enable_max_pool_asm_diff_qinfo
branch
from
1ff93da to
c94033f
Compare
gunes-arm
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict differing src/dst quantization-info support in CpuPool2dAssemblyWrapperKernel to MAX pooling, while keeping AVG pooling on the generic fallback path.
Fix the quantized multiplier validation check and wire the requantization shifts correctly for the asm pooling path so requantized MAX pooling validates and executes correctly.
Add NEON validate coverage for padded NHWC QASYMM8 MAX with differing quantization info.
Resolves MLCE-1821
Change-Id: I33c99d0d4ea1bf57ed28d0750422403e60e2a276